Login: Added custom validation for missing password and user/email on the login form #20233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the login form validation by adding custom client-side validation messages for empty username/email and password fields with localization support.
- Moved validation logic from login page to the auth element for better separation of concerns
- Added localized validation messages for required field validation
- Implemented custom CSS styling for validation message display
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Login/src/localization/lang/en-us.ts | Added English localization keys for validation messages |
| src/Umbraco.Web.UI.Login/src/localization/lang/da.ts | Added Danish localization keys for validation messages |
| src/Umbraco.Web.UI.Login/src/components/pages/login.page.element.ts | Removed validation logic and cleaned up error state handling |
| src/Umbraco.Web.UI.Login/src/auth.element.ts | Added validation logic with custom validation messages and form submission handling |
| src/Umbraco.Web.UI.Login/src/auth-styles.css | Added CSS styling for validation messages and minor formatting fix |
…ing-mandatory-fields-fix
…r control submission
…n to validation and add oninput and onblur
iOvergaard
changed the title
# Conflicts: # src/Umbraco.Web.UI.Login/src/localization/lang/en.ts
to be conventional and kebab-cased.
leekelleher
approved these changes
Nov 10, 2025
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, all working as expected! 🚀
I amended the filenames of the SVG "eye" icons for consistency.
leekelleher
deleted the
v16/bugfix/login-missing-mandatory-fields-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom validation for missing password and user/email
Added support for the message to use Localization
Moved the logic that checks for empty username and password from login.page.element.ts to auth.element.ts
login.example.mp4