Fix 14528: passwordMismatch validation message update

[piers-taylor-1994]

Fixes issue #14528.

Problem

When updating a pre-existing user’s password, the validation message shown for mismatched inputs was overly verbose and unclear.

Fix

Updated the validation error message to now display "New passwords don't match" to increase clarity and fall in-line with other password mismatch validation error messages on the site that show "Passwords don't match".

Test example

• Create a user with default password
• Attempt to edit user's password with mismatched passwords
• See validation error message

Before:

After:

Notes

• A previous PR addressing this issue was closed, but it appears the member creation and update flows have since been updated to use "Passwords don’t match".
• I've noticed there's other places in the code that reference the old "The confirmed password doesn't match the new password!" error message but they aren't affecting the UI in any places I can find. Happy to apply this fix to other places that are deemed necessary/I've missed but didn't want to affect files out of scope.

[github-actions]

Hi there @piers-taylor-1994, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nul800sebastiaan]

This does not fix the issue of the wrong error being triggered. I'll close this PR and will encourage you or other contributors to test and validate the exact use-case in the original issue to make sure the correct issue is actually being fixed.

This appears to be an AI-generated PR, or at least the description seems to be that. We have no problem with using AI to help, but please disclose the usage and also manually validate it's actually fixing the issue at hand. Thanks!

[nul800sebastiaan]

On second look through the issue, this might actually be an okay solution, but it does feel like we could add an explicit check as @mistyn8 notes: #14528 (comment)

Think that would be preferred instead of a more generic message, but I haven't looked into the code to see if this would actually work, the comments on the issue are a bit contradictory in that regard. We'll have a look soon!

[piers-taylor-1994]

@nul800sebastiaan I want to confirm that this PR is not AI-generated; this is the format I've used on other projects I'm committed to. That being said, if it gives off that impression, maybe I need to rethink how I present my future PRs!

The solution is based off me witling through the issues' description, comments and closed PR. I noticed the suggestion by @mistyn8, however, after trying to replicate the incorrect message, I noticed it happens before submission, thus happening via client-side JavaScript, so I don't think this would fix the issue. The suggestion is also specifically regarding member password changes, which seems to be displaying a friendlier "Passwords don't match" message now (which is in contrast to the original ticket/PR).

[nul800sebastiaan]

@piers-taylor-1994 Understood! I think it confused me as we have a small template to show what we expect to be filled in:

If you had amended it, with your own format under ### Description it would have made more sense! 😄