Skip to content

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Oct 2, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Added a drag handle to be consistent with other parts of backoffice UI and indicate groups are draggable.

I made it a bit more consistent with configuration of other datatypes and navigating via keyboard is not possible to see when delete button has focus.

It we want to use auto-width of group input, I think it at least should have a minimum width.

image
chrome_Gpz0Cggrxq.mp4

Copilot AI review requested due to automatic review settings October 2, 2025 22:12
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the visual styling of the block grid group drag functionality by adding proper drag handles and cursor states.

  • Adds a grip icon to visually indicate draggable groups
  • Implements proper flexbox layout for the group handle
  • Adds active cursor state for better user feedback during drag operations

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works nicely, thanks @bjarnef.

@nielslyngsoe nielslyngsoe merged commit 4330a99 into umbraco:main Oct 6, 2025
27 checks passed
@bjarnef bjarnef deleted the bugfix/block-grid-group-drag-handle branch October 6, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants