Skip to content

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Oct 2, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

Description

I noticed a few labels which seems to render just the keys/aliases.

Before

image

After

image

Copilot AI review requested due to automatic review settings October 2, 2025 23:44
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes localization issues in the block grid area configuration settings by replacing hardcoded string labels with proper localized terms. The changes ensure that property labels display translated text instead of raw keys/aliases.

  • Replaces hardcoded string literals with localized terms using this.localize.term()
  • Adds missing translation keys to both English and Danish language files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-area-config-entry/workspace/views/settings.element.ts Updates property labels to use localized terms instead of hardcoded strings
src/Umbraco.Web.UI.Client/src/assets/lang/en.ts Adds English translations for the new localization keys
src/Umbraco.Web.UI.Client/src/assets/lang/da.ts Adds Danish translations for the new localization keys

@AndyButland AndyButland changed the title Translation: Localization of property labels Localization: Added translations for area validation property labels Oct 3, 2025
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Once again, thanks @bjarnef.

@AndyButland AndyButland merged commit 5a565b7 into umbraco:main Oct 3, 2025
28 checks passed
@bjarnef bjarnef deleted the bugfix/block-editor-validation-group-labels branch October 3, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants