-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Block Grid: Add icon to allowed block types in area #20364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Grid: Add icon to allowed block types in area #20364
Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds visual icons to the block type selection dropdown in the block grid area type permissions interface to improve usability and visual identification of different block types.
- Added icon property to the block data mapping to include icon information
- Added icon display for both block groups (folder icon) and individual block types (their specific icons) in the combobox dropdown
.../property-editors/block-grid-area-type-permission/block-grid-area-type-permission.element.ts
Outdated
Show resolved
Hide resolved
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is giving me an error when building the front-end I'm afraid:
src/packages/block/block-grid/property-editors/block-grid-area-type-permission/block-grid-area-type-permission.element.ts:213:29 - error TS2339: Property 'icon' does not exist on type '{ type: UmbBlockTypeWithGroupKey; name: string; }'.
213 <uui-icon name=${block.icon}></uui-icon>
|
@AndyButland it seems it just need an |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@AndyButland can you try output If icons include colors I think it need to use |
|
Can you check with latest change as |
|
Alright, I think the latest change should fix it based on https://uui.umbraco.com/?path=/story/uui-combobox--avatars |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.




Prerequisites
Description
Added icon the combobox list with blocks to allow in specific area to easier identify the block visually.
Before
After