Skip to content

E2E Pipeline: QA Remove continue on error condition #20365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

E2E Pipeline: QA Remove continue on error condition #20365

merged 1 commit into from
Oct 3, 2025

Conversation

@andr317c
Copy link
Contributor

@andr317c andr317c commented Oct 3, 2025

Cherrypicked from v15

Copilot AI review requested due to automatic review settings October 3, 2025 06:04
Copilot AI reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a continueOnError: true condition from the E2E pipeline configuration to ensure that test failures properly halt the pipeline execution.

  • Removes the continueOnError: true setting from the Playwright test step

nhudinh0309
nhudinh0309 approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andr317c andr317c merged commit e0449d3 into main Oct 3, 2025
26 checks passed
@andr317c andr317c deleted the v16/QA/cherry-pick-pipeline-changes branch October 3, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@nhudinh0309 nhudinh0309 nhudinh0309 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andr317c @nhudinh0309