Skip to content

Conversation

@OskarKruger
Copy link
Contributor

Description

Added a label for screenreader to splitview divider.
According to Aria documentation, both valuenow and valuetext is required.

Plan to add localiztion for this text also, unsure how to combat this when split-panel-element extends from LitElement instead of UmbLitElement. Would love to hear feedback on both points :)

@iOvergaard
Copy link
Contributor

@OskarKruger

Plan to add localiztion for this text also, unsure how to combat this when split-panel-element extends from LitElement instead of UmbLitElement.

You can just change it to extend from UmbLitElement directly. Then you have access to localization.

@OskarKruger
Copy link
Contributor Author

Thank you for that tip @iOvergaard, it worked like a charm!

I added the localization with the help of UmbLitElement's implementation, and updated most commonly used lang files.
Using NVDA screenreader, this works 👍🏼

Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leekelleher leekelleher merged commit dc92cf4 into umbraco:main Oct 8, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants