Collections: Stop opening items in modals #20384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… v17/feature/stop-opening-modals-in-collections
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on removing the modal-based editing experience for collection items (Documents and Media) in Umbraco CMS v.17, aligning with the v.13 experience. Users will now stay in the main workspace rather than opening items in modal overlays, improving navigation context and user experience.
Key Changes:
- Modal removal: Collection items now open directly in workspaces instead of modal dialogs
- Path generation updates: Changed from local path building to absolute path generation for navigation
- Backend API updates: Updated property models and added new endpoint for segment options
- Test and validation updates: Updated validation messages and test helper version
Reviewed Changes
Copilot reviewed 84 out of 88 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Frontend Collection Views | Removed modal workspace builders and updated path generation to use absolute paths |
| Backend API Types | Renamed SignModel to FlagModel and updated corresponding properties across response models |
| Test Files | Updated validation message references and Playwright test helper version |
| Infrastructure | Added regex optimizations, updated project configurations, and dependency versions |
Files not reviewed (3)
- src/Umbraco.Web.UI.Client/package-lock.json: Language not supported
- src/Umbraco.Web.UI.Login/package-lock.json: Language not supported
- tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
...ackages/documents/documents/collection/views/table/document-table-collection-view.element.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/collection/default/collection-default.context.ts
Show resolved
Hide resolved
…tions # Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/tree/data/types.ts # src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/views/grid/document-grid-collection-view.element.ts
…lection/views/table/document-table-collection-view.element.ts Co-authored-by: Copilot <[email protected]>
leekelleher
approved these changes
Oct 7, 2025
nielslyngsoe
deleted the
v17/feature/stop-opening-modals-in-collections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20251
From v.17, we will stop opening Items of a Collection in modals, aligning with the experience of v.13.
This enables users to stay in touch with their location in the Tree, easier spot where they are at and navgiate to the next item of interest.