-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Dependencies: Updates all npm dependencies for Client, Login, and UmbracoExtension #20386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…les on client and template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates npm dependencies across the Client, Login, and UmbracoExtension templates, regenerates API client code with the updated @hey-api/openapi-ts tool, and includes various minor code formatting improvements.
- Updated @hey-api/openapi-ts from 0.81.1 to 0.85.0 across all projects
- Regenerated API client code which removes inline if-statements and improves maintainability
- Updated various other dependencies including TypeScript, Vite, ESLint, and external libraries
Reviewed Changes
Copilot reviewed 66 out of 70 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json files | Dependency version updates for various npm packages |
| API generated files (types.gen.ts, sdk.gen.ts, etc.) | Regenerated API client code with cleaner structure and removed conditional compilation directives |
| Icon files | Updated icon SVG paths from lucide and simple-icons libraries |
| Code formatting files | Minor formatting improvements and style fixes |
Files not reviewed (2)
- src/Umbraco.Web.UI.Client/package-lock.json: Language not supported
- src/Umbraco.Web.UI.Login/package-lock.json: Language not supported
src/Umbraco.Web.UI.Client/src/packages/core/components/input-slider/input-slider.element.ts
Show resolved
Hide resolved
...Umbraco.Web.UI.Client/src/packages/core/workspace/kinds/default/default-workspace.context.ts
Show resolved
Hide resolved
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20386.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-sea-0c7411a03-20386.westeurope.6.azurestaticapps.net |
nielslyngsoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review all code changes except the ones from the generated code, and the changes look good.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20386.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-sea-0c7411a03-20386.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20386.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-sea-0c7411a03-20386.westeurope.6.azurestaticapps.net |
Changes
Updates
Re-generate
Notes
@hey-api/openapi-ts has once again changed quite a bit in its generation, though the output of all functions seems unchanged (looks like their strategy to go to an options-based input/output pattern paid off)