Skip to content

Conversation

@iOvergaard
Copy link
Contributor

Changes

Updates

  • Updates all relevant npm dependencies in Umbraco.Web.UI.Client
  • Updates all relevant npm dependencies in Umbraco.Web.UI.Login
  • Updates all relevant npm dependencies in templates/UmbracoExtension

Re-generate

  • Icons
  • Client server-api
  • Login server-api
  • UmbracoExtension server-api (NOTE: There are no longer inline if-sentences in generates files as that is difficult to maintain)

Notes

@hey-api/openapi-ts has once again changed quite a bit in its generation, though the output of all functions seems unchanged (looks like their strategy to go to an options-based input/output pattern paid off)

Copilot AI review requested due to automatic review settings October 6, 2025 14:53
@iOvergaard iOvergaard added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code area/frontend release/17.0.0 release/16.4.0 preview/storybook Pull requests that can be previewed through Storybook preview/backoffice Pull requests that can be previewed in a static version of the Backoffice labels Oct 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates npm dependencies across the Client, Login, and UmbracoExtension templates, regenerates API client code with the updated @hey-api/openapi-ts tool, and includes various minor code formatting improvements.

  • Updated @hey-api/openapi-ts from 0.81.1 to 0.85.0 across all projects
  • Regenerated API client code which removes inline if-statements and improves maintainability
  • Updated various other dependencies including TypeScript, Vite, ESLint, and external libraries

Reviewed Changes

Copilot reviewed 66 out of 70 changed files in this pull request and generated 2 comments.

File Description
package.json files Dependency version updates for various npm packages
API generated files (types.gen.ts, sdk.gen.ts, etc.) Regenerated API client code with cleaner structure and removed conditional compilation directives
Icon files Updated icon SVG paths from lucide and simple-icons libraries
Code formatting files Minor formatting improvements and style fixes
Files not reviewed (2)
  • src/Umbraco.Web.UI.Client/package-lock.json: Language not supported
  • src/Umbraco.Web.UI.Login/package-lock.json: Language not supported

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20386.westeurope.6.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-sea-0c7411a03-20386.westeurope.6.azurestaticapps.net

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review all code changes except the ones from the generated code, and the changes look good.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20386.westeurope.6.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-sea-0c7411a03-20386.westeurope.6.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20386.westeurope.6.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-sea-0c7411a03-20386.westeurope.6.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit b4e97ea into main Oct 7, 2025
26 of 27 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/feature/npm-updates-october-2025 branch October 7, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code preview/backoffice Pull requests that can be previewed in a static version of the Backoffice preview/storybook Pull requests that can be previewed through Storybook release/16.4.0 release/17.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants