Skip to content

Conversation

@madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Oct 10, 2025

This PR wires up the client validation so that validation messages are displayed in the UI.

How to test:
Set up amount (min/max) rules in the Data Type config and verify that validation messages are shown accordingly.

Copilot AI review requested due to automatic review settings October 10, 2025 11:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements client-side validation for the Entity Data Picker property editor by integrating the Umbraco form validation system. The changes enable validation messages to be displayed in the UI when validation constraints are violated.

  • Wires up form control validation by adding the input element to the form control system
  • Replaces UUI form control mixin with Umbraco's form validation mixin
  • Adds type safety and validation for the selection value handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
entity-data-picker-property-editor-ui.element.ts Adds form control registration and validation setup in firstUpdated lifecycle method
input-entity-data.element.ts Replaces UUI form mixin with Umbraco validation mixin and updates value handling

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madsrasmussen - validation works as expected now. I added a min and max of 1, and see validation errors if saving 0 or 2 items.

@AndyButland AndyButland merged commit c68a26c into release/17.0 Oct 10, 2025
23 of 24 checks passed
@AndyButland AndyButland deleted the v17/hotfix/entity-data-picker-amount-client-validation branch October 10, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants