Refactoring: Fixed spelling mistake in method name #20460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a spelling mistake in the method name EnsurePhsyicalViewExists to EnsurePhysicalViewExists while maintaining backward compatibility through an obsolete wrapper method.
- Fixed the typo "Phsyical" to "Physical" in the method name
- Added backward-compatible obsolete method to prevent breaking changes
- Updated all references to use the correctly spelled method name
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Umbraco.Web.Common/Controllers/UmbracoPageController.cs | Added correctly spelled method, marked old method as obsolete, and updated internal usage |
| src/Umbraco.Web.Common/Controllers/RenderController.cs | Updated method call to use the correctly spelled method name |
Co-authored-by: Copilot <[email protected]>
AndyButland
added a commit
that referenced
this pull request
Oct 10, 2025
* Fixed spelling mistake in method name. * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Kenn Jacobsen <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
There's a typo in the
UmbracoPageController.EnsurePhysicalViewExistsmethod name (it wasEnsurePhsyicalViewExists). This PR fixes that in a backward compatible way.Testing
Verify that templates still render.