Skip to content

Conversation

@Migaroez
Copy link
Contributor

Description

Fixes #20370

Testing

Follow the steps in the linked issue OR

  • Enable the delivery api
  • Create a tree structure of saved but not published nodes trough the backoffice
  • Publish the root node
  • Use Publish with descendants (check include unpublished nodes) on the root node
  • Check the delivery api index (as described in the linked issue)

@AndyButland AndyButland changed the title Fix - DeliveryApi not reindexing branch descendants when branch root already published but unchanged Delivery API: Fix not reindexing branch descendants when branch root already published but unchanged (closes #20370) Oct 10, 2025
@Migaroez Migaroez force-pushed the v16/bugfix/publish-branch-deliveryApi branch from 070e36d to 7b339ba Compare October 10, 2025 14:24
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works in local testing. Previously an unpublished node would remain with published = "n" in the next even when the parent was published with unpublished children. With this update I see it's fixed with published = "y".

Maybe you could just try to clarify the comment you've added on lines 64-65 as I find it a bit hard to follow? Just to help someone coming to this in future and seeing this code fragment.

After that, happy for you to merge. You should then merge main to v17/dev and then cherry-pick this into release/17.0. The issue can then be labelled with release/16.4 and release/17.0.

@kjac
Copy link
Contributor

kjac commented Oct 13, 2025

@Migaroez code looks good 👍 but it also feels like something that can become volatile moving forward. Is there any chance I could trouble you for an integration test that proves the fix?

@Migaroez Migaroez merged commit e53220c into main Oct 14, 2025
25 checks passed
@Migaroez Migaroez deleted the v16/bugfix/publish-branch-deliveryApi branch October 14, 2025 10:15
Migaroez added a commit that referenced this pull request Oct 14, 2025
…already published but unchanged (closes #20370) (#20462)

* Fix deliveryApi not reindexing branch descendants when branch root already published and unchanged

* Commit update and name improvement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publishing items in bulk programmatically does not properly update delivery api content index

4 participants