Skip to content

Conversation

@madsrasmussen
Copy link
Contributor

When a Property Editor UI that supports Data Sources is selected, the data source becomes mandatory. This PR introduces client-side validation to provide feedback.

Copilot AI review requested due to automatic review settings October 10, 2025 12:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the data source field mandatory for data types that support data sources by adding client-side validation. When a Property Editor UI supports Data Sources, users must now select a data source before saving.

  • Added mandatory validation to the data source property layout
  • Implemented client-side validation binding using umbBindToValidation
  • Made the data source input field required

@madsrasmussen madsrasmussen changed the title Make data source field mandatory in data type details Make data source field mandatory, when supported, in data type details Oct 10, 2025
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've tested locally and confirmed that the data source is mandatory when selecting the entity data picker.

@AndyButland AndyButland enabled auto-merge (squash) October 10, 2025 13:00
@AndyButland AndyButland merged commit 2ce6c8f into release/17.0 Oct 12, 2025
24 checks passed
@AndyButland AndyButland deleted the v17/hotfix/make-data-source-mandatory branch October 12, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants