Publishing: Resolve exceptions on publish branch #20464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th expected exceptions.
…d such that UmbracoContext is available.
… can get an IUmbracoContext in the URL providers.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lauraneto
reviewed
Oct 15, 2025
There was a problem hiding this comment.
Couldn't you also add the following to the start of ContentPublishingService.PerformPublishBranchAsync()?
using UmbracoContextReference umbracoContextReference = _umbracoContextFactory.EnsureUmbracoContext();This way the code that is called after should be able to retrieve a context from the accessor, and you shouldn't need to update all of accessor calls in the url providers.
|
Thanks @lauraneto - yes, it seems that works fine, and is quite a bit simpler. I've applied your suggestion and it looks to have resolved the problem to me. |
lauraneto
approved these changes
Oct 21, 2025
lauraneto
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Reduce log level of image cropper converter to avoid flooding logs with expected exceptions. * Don't run publish branch long running operation on a background thread such that UmbracoContext is available. * Revert to background thread and use EnsureUmbracoContext to ensure we can get an IUmbracoContext in the URL providers. * Updated tests. * Applied suggestion from code review. * Clarified comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR resolves a couple of exceptions found in testing the publish branch feature.
Firstly I was seeing errors in
UrlProviderwhich requires anUmbracoContext. When publishing a branch with unpublished descendants and a webhook enabled on publish, this would get called, as the webhook payload was being created.I've amended this now so we ensure an Umbraco context exists if one can't be accessed.
Secondly we were logging errors on seemingly expected scenarios with the image cropped property value converter. So here I've reduced the log level to debug and tightened up the try/catch so we only handle the specific error.
Testing