Skip to content

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Oct 12, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

Description

I noticed media log type is stretched, because of flexbox, but not center aligned (or auto margin) like log type in content.
Much of this is redundant (and perhaps added to member as well) and maybe useful for Forms and Commerce?

<umb-history-item> should maybe have an user property and a tag/badge - or slots for these?

Or create a umb-log-type component to avoid this part to be redundant:

<span class="log-type">
	<uui-tag look=${style.look} color=${style.color}>
		${this.localize.term(text.label, item.parameters)}
	</uui-tag>
	${this.localize.term(text.desc, item.parameters)}
</span>
.log-type {
    display: grid;
    grid-template-columns: var(--uui-size-40) auto;
    gap: var(--uui-size-layout-1);
}

.log-type uui-tag {
    justify-self: center;
    height: fit-content;
    margin-top: auto;
    margin-bottom: auto;
}
image

Before

image

After

image

Copilot AI review requested due to automatic review settings October 12, 2025 14:29
@github-actions
Copy link

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the alignment of log type tags in media audit logs by adding center alignment to match the behavior in content audit logs.

  • Adds justify-self: center CSS property to center-align log type tags in media audit logs

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjarnef - I've tested out and this improves the layout as shown.

@AndyButland AndyButland changed the title Log Type: Center align log type in media UX: Center align log type in media history view Oct 13, 2025
@AndyButland AndyButland merged commit 7b4684c into umbraco:main Oct 13, 2025
28 checks passed
AndyButland pushed a commit that referenced this pull request Oct 13, 2025
@bjarnef bjarnef deleted the bugfix/media-log-type branch October 13, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants