Dependencies: Remove Microsoft.CodeAnalysis.CSharp dependency from Umbraco.Infrastructure
#20481
+5
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only needed for runtime compilation and thus is no longer needed in Infrastructure. It also caused dependency problems with EF Core Design in previous versions.
This will ensure that we face any potential dependency issues consumers are also likely to run into.
lauraneto
added
dependencies
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Microsoft.CodeAnalysis.CSharp dependency from the Umbraco.Infrastructure project, which was only needed for runtime compilation and is no longer required. Additionally, Central Package Management (CPM) is disabled for the Umbraco.Web.UI project to prevent dependency issues that consumers might encounter.
Key changes:
- Removed Microsoft.CodeAnalysis.CSharp dependency from Umbraco.Infrastructure
- Disabled CPM in Umbraco.Web.UI project and explicitly specified package versions
- Cleaned up unused CodeAnalysis package references from Central Package Management
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Infrastructure/Umbraco.Infrastructure.csproj | Removes Microsoft.CodeAnalysis.CSharp package reference |
| src/Umbraco.Web.UI/Umbraco.Web.UI.csproj | Disables CPM and adds explicit version numbers for EF Core Design and ICU packages |
| Directory.Packages.props | Removes unused CodeAnalysis package versions from central management |
…mentMode.Backoffice`
AndyButland
approved these changes
Oct 14, 2025
lauraneto
deleted the
v17/bugfix/remove-codeanalysis-dependency-from-infrastructure
branch
lauraneto
added a commit
that referenced
this pull request
Oct 14, 2025
…Umbraco.Infrastructure (#20481) * Remove Microsoft.CodeAnalysis.CSharp from Infrastructure project This was only needed for runtime compilation and thus is no longer needed in Infrastructure. It also caused dependency problems with EF Core Design in previous versions. * Disable CPM for UI project to better reflect consumers This will ensure that we face any potential dependency issues consumers are also likely to run into. * Add `Microsoft.CodeAnalysis.CSharp` reference to `Umbraco.Cms.DevelopmentMode.Backoffice`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Microsoft.CodeAnalysis.CSharpdependency in theUmbraco.Infrastructureproject was only needed for runtime compilation and thus is no longer needed.It also caused dependency problems with EF Core Design in previous .NET versions, as can be seen in #20421 and #17839. In .NET 10 these issues are no longer present, but if they re-appear we will need to apply a similar fix as in #20474.
I also disabled CPM (Central Package Management) in the
Umbraco.Web.UIproject, as that can sometimes hide dependency issues consumers might encounter.