Skip to content

News Dashboard: split into card + container, parent handles the data from the repo #20503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2025
Merged

News Dashboard: split into card + container, parent handles the data from the repo #20503

merged 4 commits into from
Oct 16, 2025

Conversation

@engijlr
Copy link
Contributor

@engijlr engijlr commented Oct 15, 2025

Summary

Refactor the news dashboard into smaller web components:

  • umb-news-card: presentational only (renders a single card).
  • umb-news-container: handles grouping by priority; accepts flat items via property.
  • umb-umbraco-news-dashboard: parent stays responsible for fetching via repository and passing items down.

@engijlr engijlr changed the title News Dashboard: split into card + container, parent handles data from the repo News Dashboard: split into card + container, parent handles the data from the repo Oct 15, 2025
@leekelleher leekelleher self-requested a review October 16, 2025 08:57
leekelleher
leekelleher approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, all good! 🙌

@leekelleher leekelleher enabled auto-merge (squash) October 16, 2025 12:37
@leekelleher leekelleher merged commit 271edb5 into v17/dev Oct 16, 2025
27 checks passed
@leekelleher leekelleher deleted the feature/news-dashboard-refactor branch October 16, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees

No one assigned

Labels

area/frontend release/17.1.0 type/improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@engijlr @leekelleher