Variant Selector: Hint badge should render in append slot #20504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a rendering issue in the workspace split view variant selector where a hint badge was missing the slot="append" attribute needed for proper positioning.
- Created a dedicated method
#renderVariantSelectorHintBadgethat includes the required slot attribute - Updated the template to use the new method instead of the generic
#renderHintBadge - Added CSS styling to ensure proper z-index positioning of the badge
AndyButland
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
Can confirm this fixes the issue. To replay testing steps:
- Created a document type that varies by culture with a text string that also varies by culture.
- Created content in two languages, leaving the text string empty in the non-default one.
- Made the text string mandatory.
- Saved and published both languages from the default language.
- With this change in place, the badge appears in the variant selector indicating a validation error in the non-default language. Opening the selector shows the badge on the language with the validation error.
- Previously the first badge wasn't visible, so there was no indication to open the selector and see the badge on the language with the validation error.
AndyButland
changed the title
nielslyngsoe
deleted the
v17/hotfix/variant-selector-validation-badge-render-in-append-slot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix minor mistake where umb-badge did not have the slot attribute defined — this is only needed for the variant-selector badge.
Additionally makes the badge go on top of the dashed-line appearing on not-created variants.
Test notes:
Trigger a validation issue on a variant and navigate to another one, a badge should appear on the variant-selector to lead the user back to correct the issue.