-
Couldn't load subscription status.
- Fork 2.8k
Make Create Actions open as dialogs (part 2) #20523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Create Actions open as dialogs (part 2) #20523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates script and document blueprint creation dialogs to open as dialog modals instead of sidebar modals, continuing the work from PR #20489 to make create actions more consistent across the Umbraco CMS interface.
Key changes:
- Convert script create modal from sidebar to dialog layout with updated UI components
- Convert document blueprint create modal from sidebar to dialog with a two-step creation process
- Replace tree-based document type selection with a picker modal for blueprint creation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| script-create-options-modal.element.ts | Updates script creation modal to use dialog layout and ref-list components instead of body layout and menu items |
| scripts/entity-actions/create/options-modal/index.ts | Changes script create modal type from sidebar to dialog |
| document-blueprint-options-create-modal.element.ts | Replaces inline document type tree with picker modal and updates to dialog layout |
| document-blueprints/entity-actions/create/modal/constants.ts | Changes document blueprint create modal type from sidebar to dialog |
...emplating/scripts/entity-actions/create/options-modal/script-create-options-modal.element.ts
Outdated
Show resolved
Hide resolved
...nt-blueprints/entity-actions/create/modal/document-blueprint-options-create-modal.element.ts
Show resolved
Hide resolved
This reverts commit 1c15dda.
This reverts commit 47d74a8.
This reverts commit f2eb1f2.
… of https://github.com/umbraco/Umbraco-CMS into v17/hotfix/adjust-position-of-remaining-create-dialogs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me testing out locally.
I noticed the Stylesheets create dialog, whilst being centred, is a little different to the scripts one. The "New Folder" item doesn't have the "..." and it does have a description. Think it would make sense to align this with what you've done for Scripts and Blueprints.
Also, in the linked issue is raised the point about when creating a member, even if there's only one member type, you still see the dialog. Not sure how you want to handle that - in this PR, ask for a separate issue to be created, or just leave it as is? But just raising so we don't miss that part of the issue.
|
@AndyButland I have pushed some additional updates to this one to align the dialogs more. I have removed the word "New" from all the options I could find. We don't use "New" when creating documents, media, etc., so I think this aligns better. Additionally, I have fixed the implementation of the ellipsis. We already supported the "additionalOptions" setting in the manifest but never implemented it in the dialog. If we need further alignment, I think we should invest time in correctly registering all options as an "entityCreateOptionAction" so they all go through the same dialog/UI and we can remove a bunch of custom dialogs. The PR doesn't target the single option dialog. I think it could make sense that the Management Api returns the "allowedChildren" information from the Content Type on a Document Tree Model. This would give us some extra capabilities on the frontend:
@andr317c Will you help fix merge conflicts in this one? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me from the perspective of the dialogs now.
I've taken a note about the suggestion on the content responses from the trees including the allowed children - we can look at the feasibility of that in a separate PR. My only concern is that it's another database look up, which is probably why we currently get this information only having clicked on "Create".
Just one tiny thing, mentioning only if easy to do something about, is that there's a small but perceptible flicker on the document and media create dialogs where the briefly appear in the left and then move to the centre. I don't see it on the dialogs under "Settings". Might just be it's too quick to see. No reason that should hold up this PR though.
…ing-create-dialogs
|
@AndyButland I have noticed the dialog flicker too. It is a problem with all dialogs, so I would like to keep it out of this PR. |
…ing-create-dialogs
Fixes: #20516
Updates script and Blueprint dialogs that were missed in this PR: #20489
This PR fixes the script create dialog:

And updates the Blueprint dialog to match the other create option dialogs. Instead of displaying the Document Type Tree directly in the dialog, it is now a two-step process: first select create blueprint, then choose the document type.