Item Repository: Sort statuses by order of unique #20603
Merged
+120
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a synchronization issue between the UI order and the internal sort model in the Item Repository. When iterating through the status array, the order was not being maintained correctly. The changes ensure that the statuses array is kept in sync with the unique items' sort order by implementing a new replace method and deprecating the now-unnecessary removeStatus method.
Key changes:
- Introduced a
replacemethod forUmbArrayStateto update existing items while preserving order - Modified
UmbRepositoryItemsManagerto synchronize status sorting with item sorting - Deprecated the
removeStatusmethod as statuses are now automatically managed viasetUniques
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/Umbraco.Web.UI.Client/src/packages/core/repository/repository-items.manager.ts |
Updated status management to sort by unique order, deprecated removeStatus method, changed from append to replace for status updates |
src/Umbraco.Web.UI.Client/src/packages/core/picker-input/picker-input.context.ts |
Removed now-deprecated removeStatus call from item removal logic |
src/Umbraco.Web.UI.Client/src/libs/observable-api/utils/replace-in-unique-array.function.ts |
New utility function to replace items in unique arrays by matching unique identifiers |
src/Umbraco.Web.UI.Client/src/libs/observable-api/utils/index.ts |
Exported the new replaceInUniqueArray function |
src/Umbraco.Web.UI.Client/src/libs/observable-api/states/array-state.ts |
Added replace method to support replacing existing entries while maintaining array order |
src/Umbraco.Web.UI.Client/src/libs/observable-api/states/array-state.test.ts |
Added test coverage for the new replace method and updated test variable naming from subject to state |
src/Umbraco.Web.UI.Client/src/libs/observable-api/utils/replace-in-unique-array.function.ts
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/libs/observable-api/utils/replace-in-unique-array.function.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/libs/observable-api/states/array-state.ts
Outdated
Show resolved
Hide resolved
…-state.ts Co-authored-by: Copilot <[email protected]>
madsrasmussen
approved these changes
Oct 22, 2025
madsrasmussen
added
release/17.0.0
type/bug
status/regression
nielslyngsoe
added a commit
that referenced
this pull request
Oct 22, 2025
* utility * ability to replace * deprecate removeStatus * no need to call this any longer * Sort statuses and ensure not appending statuses, only updating them # Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/repository/repository-items.manager.ts
AndyButland
pushed a commit
that referenced
this pull request
Oct 28, 2025
* utility * ability to replace * deprecate removeStatus * no need to call this any longer * Sort statuses and ensure not appending statuses, only updating them # Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/repository/repository-items.manager.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now iterate through the status array, the UI order is no longer synchronized with the order model. The PR ensures that the statuses array order is kept in sync with the sort model order.