Skip to content

Conversation

@ronstarling9
Copy link

Problem

  • When copying and pasting blocks in tiptap editor, duplicate contentKeys are created
  • This causes issues with block identification and content management

Solution

  • Generate new unique contentKeys when pasting blocks
  • Ensures each pasted block has a distinct identifier

Testing

  • Build successful
  • Tested copy/paste functionality with multiple blocks

Fixes #20568

Fixed issue where copying and pasting RTE blocks resulted in duplicate blocks
that shared the same contentKey. Now generates new unique IDs for pasted blocks
to ensure they are independent.

Resolves umbraco#20568
@github-actions
Copy link

Hi there @ronstarling9, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂


// Insert the modified content
const parser = new DOMParser();
const doc = parser.parseFromString(modifiedHtml, 'text/html');

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.

// Insert the modified content
const parser = new DOMParser();
const doc = parser.parseFromString(modifiedHtml, 'text/html');

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copied block in Tiptap

1 participant