Skip to content

Conversation

@engijlr
Copy link
Contributor

@engijlr engijlr commented Oct 27, 2025

Summary

Update some Property Editors to align with the FormControl validation pattern.

Changes

  • Number Property Editor
    • Added mandatory support.
  • Tags Property Editor
    • Updated to extend UmbFormControlMixin.
    • Registered inner <umb-tags-input>.
    • Added support for required and required message.
  • Slider Property Editor
    • Added support for required and required message.
  • Toggle Property Editor
    • Removed unnecessary ternary in the onChange method.

@engijlr engijlr changed the base branch from main to v17/dev October 28, 2025 10:16
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and works as described 🥳

@madsrasmussen madsrasmussen enabled auto-merge (squash) October 28, 2025 12:00
@madsrasmussen madsrasmussen merged commit 8733230 into v17/dev Oct 28, 2025
26 of 27 checks passed
@madsrasmussen madsrasmussen deleted the v17/improvement/property-editors-common-group branch October 28, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants