Installer: Fix issues with newsletter signup #20705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the installer's user creation step to improve newsletter subscription handling and logging. The changes modernize the newsletter subscription process by updating the endpoint and improving error handling with proper logging.
Key changes:
- Adds logger injection to CreateUserStep for better observability of newsletter subscription operations
- Updates newsletter subscription to use new endpoint (
emailcollector.umbraco.io/api/EmailProxy) with proper data model - Replaces silent failure handling with structured logging for subscription attempts
- Removes username logging from telemetry consent for privacy reasons
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/Umbraco.Infrastructure/Installer/Steps/CreateUserStep.cs | Added logger parameter, new obsolete constructor for backward compatibility, updated newsletter subscription logic with new endpoint and EmailModel, improved error handling with logging, removed unused using statements |
| src/Umbraco.Core/Services/MetricsConsentService.cs | Removed username from telemetry level logging and formatted code for readability |
| src/Umbraco.Cms.Api.Management/ViewModels/Installer/UserInstallRequestModel.cs | Changed SubscribeToNewsletter property from get-only to get/set to allow proper data binding |
Migaroez
approved these changes
Nov 7, 2025
Contributor
Migaroez
left a comment
Migaroez
left a comment
There was a problem hiding this comment.
Looks good and works as described.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Please also read the internal chat in the CMS group Slack channel.
Description
Investigating the newsletter sign-up feature on the installation screen I found a few issues:
false.FormUrlEncodedwas incorrectly JSONThis PR fixes this by:
One little addition - I removed the logging of the user name (possibly email address) when recording the telemetry selection, as we shouldn't really have this in the logs.
Also fixed indentation, so best to review with "hide whitespace".
Testing
Install Umbraco and tick the box to sign-up with an email address that won't already be signed up for Umbraco newsletters.
You should get an email from "Lars from Umbraco" indicating that the sign-up has completed.
The success or otherwise is also written to the log file.