-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Migrations: Ensures Folder media type has a collection view on migration and moves last synched table to a pre-migration
#20743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2ce2bc3
Creating and adding new migration. And fixing another small bug.
NillasKA 57dcb36
Merge branch 'main' into v17/add-migration-to-media-bugfix
NillasKA b5c8e8c
Adding XML Header and renaming to a more clearly defined name
NillasKA 5c34d81
Merge remote-tracking branch 'origin/v17/add-migration-to-media-bugfi…
NillasKA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...nfrastructure/Migrations/Upgrade/V_17_0_0/EnsureDefaultMediaFolderHasDefaultCollection.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| using Umbraco.Cms.Core.Models; | ||
| using Umbraco.Cms.Core.Services; | ||
| using Constants = Umbraco.Cms.Core.Constants; | ||
|
|
||
| namespace Umbraco.Cms.Infrastructure.Migrations.Upgrade.V_17_0_0; | ||
|
|
||
| /// <summary> | ||
| /// Ensures that the Media Document Type called "Folder" gets a collection added to it. | ||
| /// </summary> | ||
| public class EnsureDefaultMediaFolderHasDefaultCollection : AsyncMigrationBase | ||
| { | ||
| private readonly IMediaTypeService _mediaTypeService; | ||
| private readonly IDataTypeService _dataTypeService; | ||
|
|
||
| public EnsureDefaultMediaFolderHasDefaultCollection( | ||
| IMigrationContext context, | ||
| IMediaTypeService mediaTypeService, | ||
| IDataTypeService dataTypeService) | ||
| : base(context) | ||
| { | ||
| _mediaTypeService = mediaTypeService; | ||
| _dataTypeService = dataTypeService; | ||
| } | ||
|
|
||
| protected override async Task MigrateAsync() | ||
| { | ||
| IMediaType? folderMediaType = _mediaTypeService | ||
| .Get(Guid.Parse("f38bd2d7-65d0-48e6-95dc-87ce06ec2d3d")); // Folder media type default key. | ||
|
|
||
| if (folderMediaType is null || folderMediaType.ListView is not null) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| IDataType? dataType = await _dataTypeService.GetAsync(Guid.Parse("3a0156c4-3b8c-4803-bdc1-6871faa83fff")); // Media Collection default key. | ||
|
|
||
| if (dataType is null) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| folderMediaType.ListView = dataType.Key; | ||
| await _mediaTypeService.UpdateAsync(folderMediaType, Constants.Security.SuperUserKey); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.