Skip to content

Conversation

Kull1z
Copy link
Contributor

@Kull1z Kull1z commented Sep 4, 2024

Added info so that you can set a timespan for HSTS.

Description

What did you add/update/change?

Type of suggestion

  • Typo/grammar fix
  • [x ] Updated outdated content
  • [x ] New content
  • [x ] Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

Added info so that you can set a timespan for HSTS.
@sofietoft
Copy link
Contributor

Thanks for the PR @Kull1z ! 💪

I'll make sure we get it reviewed as soon as possible!

@sofietoft sofietoft added category/umbraco-cms review/developer Use this label if an internal developer review is required labels Sep 4, 2024
Copy link
Contributor Author

@Kull1z Kull1z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sofietoft
Copy link
Contributor

Hi again @Kull1z ! 👋

After talking this over with one of our developers, we agreed that this is more a general ASP.Core thing, and therefore not something we want to add to the Umbraco docs.
The main reason for this, is that we want to avoid having to maintain documentation that is already documented (and maintained) elsewhere.

So, as this is still valuable information, how about we link to the Microsoft docs for this instead: https://learn.microsoft.com/en-us/aspnet/core/security/enforcing-ssl?view=aspnetcore-8.0&tabs=visual-studio%2Clinux-ubuntu#http-strict-transport-security-protocol-hsts

And then write something like this instead:

It is possible to configure a timespan for the HSTS, preferably six months. This can be done by adding and new builder to the Program.cs file. Learn more in the official Microsoft Documentation.

What do you think?

@sofietoft
Copy link
Contributor

Hi @Kull1z !

It's been a while since I've back from you, so I've taken the liberty to update the PR myself.
Instead of the code snippet, I added a link to the official ASP.NET docs about this topic.
That way we don't risk adding code to our docs, that might become obsolete over time 💪

Thanks again for helping up making the docs better! MUCH appreciated.

I'll get this merged.

@sofietoft sofietoft merged commit e582c5c into umbraco:main Sep 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/umbraco-cms review/developer Use this label if an internal developer review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants