Skip to content

Conversation

@georgebid
Copy link
Contributor

@georgebid georgebid commented Sep 10, 2024

Description

I noticed that the image was small and on the same line as step 4, so quickly updated it to fix this. I swapped it to use HTML <figure> with a <img> tag as this seems to be done in many other places.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

I noticed that the image was really small + on the same line as step 4, so quickly updated it to fix this
@sofietoft
Copy link
Contributor

Thanks for the PR @georgebid ! 💪
That image did look a bit misplaced, so thanks a bunch for taking the time to fix it.

Whether the markdown or the HTML format is used, does not really matter actually.
A little history, if you're interested:
The markdown format is what we've always used in the docs, so this is kinda what we default to doing in the docs team.
The HTML format with the

and

tags, is what's added to the files, when we add images directly through the GitBook platform 😄

So yeah, both methods are valid. We should probably at some point make this consistent throughout the docs.. but you know, recourses and all!

Anywho! Sorry for the wall of text!
Thanks again for the PR - I'll get it merged 💪

@sofietoft sofietoft merged commit efead75 into umbraco:main Sep 11, 2024
@georgebid
Copy link
Contributor Author

Ah, interesting. That's good to know as I haven't contributed to the docs before! Thanks for merging 😄

@georgebid georgebid deleted the patch-1 branch September 11, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants