-
Notifications
You must be signed in to change notification settings - Fork 809
Sectionview: fixed existing example + added extra examples #6455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR @Yinzy00 ! 🙌 I'll make sure we get this reviewed as soon as possible! |
14/umbraco-cms/customizing/section-trees/sections/section-view.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/customizing/section-trees/sections/section-view.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sofietoft Looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR @Yinzy00 ! 💪
I've added some comments, mostly to add more context to the guide.
Also, for the code snippets, instead of using the bold text for the file name, how about we use the following formatting for adding the file name directly to the code snippet:
{% code title="file.name" %}
code snippet goes here.
{% endcode %}
|
Thanks for applying the suggestions 💪 Since you created this PR, we've made some structural changes in the Customizing the Backoffice section, and that means we've run into a merge conflict here 🙈 I'm afraid you're gonna have to take the changes from this PR and create a new one where you update the article in the new structure 🙈 |
|
@Yinzy00 - did you see my previous message? Let me know if you want me to move over the changes to the correct file. |
|
@sofietoft , yes but haven't found the time to fix it yet. I'll try to do it this weekend. |
|
@sofietoft , i created a new PR #6603 . |
Description
I updated the already existing example which wasn't up to date with the current version of the ManifestSectionView.
I also added a typescript example of how to define the manifest + added a lit component example as reference to the linked element in the manifest.
Type of suggestion
Product & version (if relevant)
V14, v15