Skip to content

Conversation

@Yinzy00
Copy link
Contributor

@Yinzy00 Yinzy00 commented Sep 24, 2024

Description

I updated the already existing example which wasn't up to date with the current version of the ManifestSectionView.

I also added a typescript example of how to define the manifest + added a lit component example as reference to the linked element in the manifest.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

V14, v15

@sofietoft
Copy link
Contributor

Thanks for the PR @Yinzy00 ! 🙌

I'll make sure we get this reviewed as soon as possible!

@sofietoft sofietoft added the state/needs-investigation This requires input from HQ or community to proceed label Sep 25, 2024
@sofietoft sofietoft requested a review from Frost117 October 2, 2024 06:54
Copy link
Contributor

@Frost117 Frost117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sofietoft Looks good to me :)

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR @Yinzy00 ! 💪

I've added some comments, mostly to add more context to the guide.

Also, for the code snippets, instead of using the bold text for the file name, how about we use the following formatting for adding the file name directly to the code snippet:

{% code title="file.name" %}

code snippet goes here.

{% endcode %}

@sofietoft
Copy link
Contributor

Thanks for applying the suggestions 💪
The articles looks great 🎉

Since you created this PR, we've made some structural changes in the Customizing the Backoffice section, and that means we've run into a merge conflict here 🙈
The article you've updated has been moved: https://docs.umbraco.com/umbraco-cms/customize-the-backoffice/extending-overview/extension-types/section-view

I'm afraid you're gonna have to take the changes from this PR and create a new one where you update the article in the new structure 🙈
If you grab the articles you've changes, and then copy them into a new branch based off the current main branch. That should put us on the right track 💪

@sofietoft
Copy link
Contributor

@Yinzy00 - did you see my previous message?

Let me know if you want me to move over the changes to the correct file.
I can get a little complicated when resolving merge conflicts like these.

@Yinzy00
Copy link
Contributor Author

Yinzy00 commented Oct 18, 2024

@sofietoft , yes but haven't found the time to fix it yet. I'll try to do it this weekend.

@Yinzy00
Copy link
Contributor Author

Yinzy00 commented Oct 28, 2024

@sofietoft , i created a new PR #6603 .

@sofietoft sofietoft closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/umbraco-cms state/needs-investigation This requires input from HQ or community to proceed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants