Umbraco Commerce v15 updates #6637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @mattbrailsford 🙌 We will review it as soon as possible. 💪 |
eshanrnh
requested changes
Nov 12, 2024
There was a problem hiding this comment.
The PR looks good, @mattbrailsford 🙌 I've left some suggestions to shorten long sentences. Can you take a look at them?
15/umbraco-commerce/key-concepts/readonly-and-writable-entities.md
Outdated
Show resolved
Hide resolved
eshanrnh
reviewed
Nov 13, 2024
Co-authored-by: Esha Noronha <[email protected]>
Co-authored-by: Esha Noronha <[email protected]>
|
@eshanrnh just 2 suggestions, otherwise all good 👍 |
|
Great 🙌 We'll merge in this PR tomorrow - 14th Nov. |
eshanrnh
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated code examples to use the new async APIs
Type of suggestion
Product & version (if relevant)
Umbraco Commerce v15
Deadline (if relevant)
14th November 2024