Update two-factor-authentication.md #7476
Open
+40
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated members two factor example code for Umbraco v16
|
Thanks for the PR, @AaronSadlerUK 🙌 We will review it asap. |
eshanrnh
requested changes
Oct 13, 2025
There was a problem hiding this comment.
@AaronSadlerUK Thanks again for updating the code snippet. However, I had to make a few small adjustments to get the code working, which I have added as suggestions. Without these changes, the proposed snippet was throwing compilation errors.
Could you take a look and let me know if anything doesn’t make sense?
| {% code title="ExampleMemberPage.cshtml" lineNumbers="true" %} | ||
|
|
||
| ```csharp | ||
| @using Umbraco.Cms.Core.Services; |
There was a problem hiding this comment.
Suggested change
| @using Umbraco.Cms.Core.Services; | |
| @using Umbraco.Cms.Core.Models; |
| { | ||
| var setupData = await twoFactorLoginService.GetSetupInfoAsync(profileModel.Key, providerName); | ||
| foreach (var provider in providerNameList) | ||
| {0 |
| <button type="submit">Disable @providerName</button> | ||
| @using (Html.BeginUmbracoForm<UmbTwoFactorLoginController>(nameof(UmbTwoFactorLoginController.ValidateAndSaveSetup))) | ||
| { | ||
| <h3>Setup @providerName</h3> |
There was a problem hiding this comment.
Suggested change
| <h3>Setup @providerName</h3> | |
| <h3>Setup @provider.ProviderName</h3> |
| <h3>Setup @providerName</h3> | ||
| <img src="@qrCodeSetupData.SetupCode.QrCodeSetupImageUrl"/> | ||
| <p>Scan the code above with your authenticator app <br /> and enter the resulting code here to validate:</p> | ||
| <input type="hidden" name="providerName" value="@providerName" /> |
There was a problem hiding this comment.
Suggested change
| <input type="hidden" name="providerName" value="@providerName" /> | |
| <input type="hidden" name="providerName" value="@provider.ProviderName" /> |
Comment on lines
+228
to
+229
| <input type="hidden" name="providerName" value="@providerName"/> | ||
| <button type="submit">Disable @providerName</button> |
There was a problem hiding this comment.
Suggested change
| <input type="hidden" name="providerName" value="@providerName"/> | |
| <button type="submit">Disable @providerName</button> | |
| <input type="hidden" name="providerName" value="@provider.ProviderName" /> | |
| <button type="submit">Disable @provider.ProviderName</button> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated members two factor example code for Umbraco v16
📋 Description
Updated the example code in the documentation to work with Umbraco v16
📎 Related Issues (if applicable)
Solves:
umbraco/Umbraco-CMS#18880