Vertical Taskbar Widgets support#523
Conversation
…otaarryan/FluentFlyout into feature/custom-widget-position
Hi @notaarryan, just going to respond here so it's cleaner: this looks great so far! It's a good compromise to rotate the widget 90 degrees to fit the text, hopefully other users wouldn't mind either. Regarding any adjustments, I'd say it would be good to rotate the album art and buttons back 90 degrees so that they're still facing the right way, what do you think? |
Hi @unchihugo, thanks for the feedback! I agree rotating the album art back makes sense and it should look good. However, rotating the buttons back might look a bit off since they'd be horizontal inside a vertical widget — it could feel inconsistent. |
|
That's fine too, do you have any recommendations on how to test this out with a vertical taskbar? I'm on Windows 11 myself so the option isn't native anymore :) |
You will have to install ExplorerPatcher, this app lets you customize the taskbar, once you install it you have to right click on taskbar and the app pops up. |
@unchihugo Have you tested the implementation out? If so I will start working on the counter rotation of album and the buttons, I checked the buttons wont look that weird |
|
@notaarryan I'm busy right now, though I'll be able to test out the implementation soon. |
unchihugo
left a comment
There was a problem hiding this comment.
Hi @notaarryan, just tested it out and it works quite good so far, nice work! There are a few issues worth noting though, I'll list them down:
- After some testing, I've noticed that the right-aligned setting doesn't work (though left and center do work perfectly fine)
- Same goes for widget padding, if this setting is enabled and the widget is placed at the left of the taskbar, it works, but not when the widget is placed at the right of the taskbar. Since this is low-priority, we can skip this implementation for now.
Thanks for testing! I'll get bug 1 fixed. As for bug 2, would you like me to fix that as well or leave it for now? |
Let's get 1 in for now, we can leave 2 for another time! Are you also able to rotate the visualizer by 90 degrees as well?
Yes, works great! |
…otaarryan/FluentFlyout into feature/custom-widget-position
|
@unchihugo I fixed both the bugs, can you just review them |
unchihugo
left a comment
There was a problem hiding this comment.
Hi @notaarryan, just quickly checked the changes and functionality wise, it looks good. I've noticed though that the isVertical code blocks are basically duplicates of the original codes with some changes.
Could you go over the code and try to refactor and merge the new functionality into the existing code instead? That'd improve readability and maintainability a ton for everyone. Thank you for your help!
Hi @unchihugo, I'll get to it asap. |
unchihugo
left a comment
There was a problem hiding this comment.
Hey @notaarryan, this is looking much better already! I'm just curious, why did you remove or edit a lot of the comments from the existing code? Those were really helpful for contributors editing that part of the code.
Also, have you tested if it works on all modes (left, right, center, widget on/off for all positions)?
Hey @unchihugo, Sorry about that, must have happened when I was refactoring, I'll add them back I tested a few modes If you want I can test all of them and provide ss in here? |
It's alright, I'd appreciate if you'd add them back!
I'd love to see the results of all configs :) |
|
Hi @notaarryan, are you still working on this PR? I'd love to get it finalized :) |
@unchihugo Hey I am still working on it I was preoccupied with my uni work I will get to it today. |
Ah, no problem, prioritize your uni work! |
|
Hi @notaarryan, still some comment mess here and there, but it's low priority. Could you provide the test results and screenshots? |
Adds vertical taskbar support for the Taskbar Widget, resolving the issue where the widget would appear incorrectly on vertical taskbars.
Changes
Detects vertical taskbar orientation automatically based on taskbar dimensions
Rotates the widget 90° using LayoutTransform so content displays correctly
Top/Center/Bottom positioning all work correctly on vertical taskbars
Widget is centered horizontally within the slim vertical taskbar
Taskbar Visualizer positioning updated for vertical orientation
Window region clipping correctly accounts for the rotated widget bounds
Closes #493