Skip to content

[WIP] resume other media on pause#631

Draft
nopeless wants to merge 2 commits intounchihugo:masterfrom
nopeless:feat-resume-previous-media
Draft

[WIP] resume other media on pause#631
nopeless wants to merge 2 commits intounchihugo:masterfrom
nopeless:feat-resume-previous-media

Conversation

@nopeless
Copy link
Copy Markdown
Contributor

@nopeless nopeless commented Mar 31, 2026

#144

Currently, no configuration is needed. If UX is ok, supporting UI config should be introduced to this branch

@github-actions github-actions bot added the MainWindow / Media Flyout Changes to MainWindow including the Media Flyout label Mar 31, 2026
@nopeless
Copy link
Copy Markdown
Contributor Author

nopeless commented Mar 31, 2026

@jh30uk you can test out the build by uninstalling fluent flyout, and installing the version here (edit, wrong link)

@nopeless
Copy link
Copy Markdown
Contributor Author

actually im not sure if you have to uninstall fluent flyout, just know that it might cause problems if you have both running, be careful

@nopeless
Copy link
Copy Markdown
Contributor Author

https://github.com/nopeless/FluentFlyout/actions/runs/23824185599
latest msix per hash bccdd89

@jh30uk
Copy link
Copy Markdown

jh30uk commented Apr 3, 2026

It works 100% fine, and it is even more reliable then before for pausing the media.

@nopeless
Copy link
Copy Markdown
Contributor Author

nopeless commented Apr 3, 2026

@jh30uk ok, can you get back on this after you have used for a few days? to make sure there are no bugs. once you confirm, @unchihugo can make the settings ui for that

@jh30uk
Copy link
Copy Markdown

jh30uk commented Apr 6, 2026

It works fine and the odd glitch of not pausing the media since day one was on my daily Windows install (it is in need of a wipe as getting glitchy) but on my test Fresh/bare min USB install it works 99.9% of the time and therefor the new resume also works.

I assume v2.10.1 will not include this function for now?

@jh30uk
Copy link
Copy Markdown

jh30uk commented Apr 8, 2026

Bump!

@unchihugo
Copy link
Copy Markdown
Owner

Will get to this once I'm free! I'm thinking of moving this feature to Advanced Settings, since it's not necessary related to the Media Flyout (where it currently is). Are you guys fine with that?

@jh30uk
Copy link
Copy Markdown

jh30uk commented Apr 8, 2026

Yea one small thing, can we get a a delay as it may piss some peeps off as if you use the mouse cursor to skip forward using the timeline in YouTube the other previous audio will resume until you click the mouse again (so if you are clicking the timeline multiple times to find a certain spot its a bit of a PIA).

It does not do this if you use the cursor keys to skip forward on the timeline.

A setting to let us choose between 0-5secs would fix this IMO.

@nopeless
Copy link
Copy Markdown
Contributor Author

nopeless commented Apr 8, 2026

Will get to this once I'm free! I'm thinking of moving this feature to Advanced Settings, since it's not necessary related to the Media Flyout (where it currently is). Are you guys fine with that?

I don't see myself using the feature, but it seems appropriate

Yea one small thing, can we get a a delay as it may piss some peeps off as if you use the mouse cursor to skip forward using the timeline in YouTube the other previous audio will resume until you click the mouse again (so if you clicking the timeline many times to find a certain spot its a bit of a PIA).

It does not do this if you use the cursor keys to skip forward on the timeline.

A setting to let us choose between 0-5secs would fix this IMO.

@jh30uk nice catch. this is why you don't really roll out features fast, like, I never could have thought of that happening. I'll look into this for a bit

@nopeless
Copy link
Copy Markdown
Contributor Author

nopeless commented Apr 8, 2026

I looked into the api and there isn't an explicit "is scrubbing", but there is a "change position" event, meaning that we can kinda guess what the user is doing by checking their scrubbing state. Does this seem like a good idea?

@jh30uk
Copy link
Copy Markdown

jh30uk commented Apr 8, 2026

Sure and I will gladly test it for you.

@nopeless
Copy link
Copy Markdown
Contributor Author

nopeless commented Apr 9, 2026

@jh30uk @unchihugo while implementing the feature, I found a bug?, the resume feature just completely messes up user experience. I need a resolution for this #675

@nopeless nopeless marked this pull request as draft April 9, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MainWindow / Media Flyout Changes to MainWindow including the Media Flyout

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants