Remove usage of deprecated validate_arguments #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible patch for issue: unionai-oss#1663
Collaborator
|
thanks @kunalgupta02209 ! do we need to add a conditional here to change for pydantic v2? Pandera supports v2 and <2 for now. See here for an example on how to do this: https://github.com/unionai-oss/pandera/blob/main/pandera/typing/pandas.py#L187-L205 |
Collaborator
|
Also, can you please follow these steps to make the DCO commit signing check to pass? |
Collaborator
|
friendly ping, please see comment to how to address test failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible patch for issue: #1663