Speed up LCA check #4754
Draft
Speed up LCA check #4754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ChrisPenner
commented
Mar 6, 2024
Comment on lines
+2762
to
+2770
| WITH x_ancestors(id) AS ( | ||
| $selectAncestorsOfX | ||
| ), y_ancestors(id) AS ( | ||
| $selectAncestorsOfY | ||
| ) SELECT id FROM ( | ||
| SELECT id FROM x_ancestors | ||
| INTERSECT | ||
| SELECT id FROM y_ancestors | ||
| ) LIMIT 1 |
There was a problem hiding this comment.
I haven't tested this, (maybe I need a table alias?)
Not sure there's any guarantee of correct row order coming out of an INTERSECT, so should probably find a way to do that or we might not get the LEAST common ancestor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4753 ;
This rewrites the in-haskell LCA detector to pure SQLite.
Not sure how well tested this function is right now, and don't have time to work on this since it's just something I noticed while fixing bugs, so I'll just leave this here in case someone has time to look at it 🤞🏼