Skip to content

fix: check open when focusing menu items #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

fix: check open when focusing menu items #2110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/core/src/Menu/MenuItemImpl.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<script lang="ts">
import type { PrimitiveProps } from '@/Primitive'
import { injectMenuContext } from './MenuRoot.vue'

export interface MenuItemImplProps extends PrimitiveProps {
/** When `true`, prevents the user from interacting with the item. */
Expand Down Expand Up @@ -28,18 +29,17 @@ defineOptions({

const props = defineProps<MenuItemImplProps>()

const menuContext = injectMenuContext()
const contentContext = injectMenuContentContext()
const { forwardRef } = useForwardExpose()
const { CollectionItem } = useCollection()

const isFocused = ref(false)

async function handlePointerMove(event: PointerEvent) {
if (event.defaultPrevented)
return
if (!isMouseEvent(event))
if (event.defaultPrevented || !isMouseEvent(event) || !menuContext.open.value) {
return

}
if (props.disabled) {
contentContext.onItemLeave(event)
}
Expand Down