Skip to content

fix: useId with dynamic properly access #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

fix: useId with dynamic properly access #2124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/core/src/shared/useId.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,15 @@ export function useId(deterministicId?: string | null | undefined, prefix = 'rek
if (deterministicId)
return deterministicId

if ('useId' in vue) {
return `${prefix}-${vue.useId?.()}`
// Check if Vue has useId support (Vue 3.5+)
// We use dynamic property access to avoid bundler warnings in Vue < 3.5
const methodName = 'use' + 'Id'
if (typeof (vue as any)[methodName] === 'function') {
return `${prefix}-${(vue as any)[methodName]()}`
}

const configProviderContext = injectConfigProviderContext({ useId: undefined })

if (configProviderContext.useId) {
return `${prefix}-${configProviderContext.useId()}`
}
Expand Down