Skip to content

Conversation

Saeid-Za
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR only includes the partial UI changes in the website, no changes were applied to the charts themselves.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@mustafadilmac
Copy link

Hello, why hasn't this great PR been accepted yet? If this development had not been made, I was thinking of opening the same PR. Is there a reason or problem that I don't understand?

@Saeid-Za
Copy link
Contributor Author

Hello,
This was a WIP PR which i'm not working on anymore, as far as I know there is no active development on adding charts.

Please feel free to continue or even start from scratch in a new PR.

As far as I remember the main challenge is that the underlying charting library that we are using has some limitations that would make it hard to implement all samples from shad/cn.

Also, please do create an issue before attempting on a PR, so that the maintainers could update you on the progress which I'm not aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants