Fix LTO regressions in nightly toolchain #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riusricardo
reviewed
May 12, 2020
There was a problem hiding this comment.
The build command is fixed but generating the metadata is broken.
I get a cc linker error.
flipper/target/release/deps/flipper.flipper.8f0qzq8t-cgu.0.rcgu.o: file not recognized: File format not recognized
collect2: error: ld returned 1 exit status
EDIT: Same error as in the tests :(
Collaborator
Author
|
@riusricardo indeed I am working on troubleshooting this as we speak |
Collaborator
Author
|
As a workaround you can comment out I'm working on doing this automatically but in the meantime this should suffice. |
ascjones
changed the title
ascjones
changed the title
Collaborator
Author
|
@riusricardo could you try again now, and see if it works for you? |
|
@ascjones everything is working again 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for use-ink/ink#391.
Recent nightly has broken since rust-lang/rust#71925 (see rust-osdev/cargo-xbuild#69 (comment))
cargo-xbuildwhich adds LTO flag to sysroot build: Set-Clinker-plugin-ltofor the sysroot build rust-osdev/cargo-xbuild#71.file not recognized: File format not recognized. rel: Add default[profile.release]values to Cargo.toml if not present #40