Update Heading CSS modules to not collide #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbax
approved these changes
Nov 13, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
rsaris
commented
Nov 13, 2025
| @@ -1,31 +1,31 @@ | |||
| .large { | |||
| .sizeLarge { | |||
Contributor
Author
There was a problem hiding this comment.
Probably overkill but figured it's better to over describe here, especially since this doesn't leak outside of this component.
| } | ||
|
|
||
| .medium { | ||
| .weightMedium { |
Contributor
Author
There was a problem hiding this comment.
Here was the issue -- had two "medium" classes in the same file so they both came together when I only wanted one at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I messed up and didn't think about module collision in my naming.