Open
Conversation
Collaborator
|
Can you update your PR to go against the Tahoe branch? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS Tahoe 26 beta releases include a possible bug or change to the
runfunction in JXA. Therunfunction is actually only really useful for inputting command line arguments.As far as I can make out, the
$ODVvalues are not submitted as command line arguments, rather they are substituted directly into the scripts on generation. Therefore, the run function is not required in any of the JXA snippets used in the mSCP.This PR removes the run function from all snippets, which removes any potential issues with changes to the
runfunction.