rm: add the --progress option like with cp & mv #8567

sylvestre · 2025-09-06T23:13:19Z

No description provided.

github-actions · 2025-09-06T23:36:27Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-09-07T08:04:40Z

GNU testsuite comparison:

GNU test failed: tests/rmdir/symlink-errors. tests/rmdir/symlink-errors is passing on 'main'. Maybe you have to rebase?

github-actions · 2025-09-14T19:23:58Z

GNU testsuite comparison:

GNU test failed: tests/rmdir/symlink-errors. tests/rmdir/symlink-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2025-09-14T20:51:48Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions · 2025-09-14T21:31:40Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

cakebaker · 2025-09-24T12:30:38Z

tests/by-util/test_rm.rs

+    // Test that -g/--progress flag is accepted
+    ucmd.arg("-g").arg(file).succeeds();


There is a disconnect between the code and the comment. I would either adapt the code to test both -g and --progress or change/remove the comment.

cakebaker · 2025-09-24T12:44:48Z

tests/by-util/test_rm.rs

+    let (_, mut ucmd) = at_and_ucmd!();
+    let nonexistent_file = "this_file_does_not_exist";
+
+    // Test that progress bar is not shown when file doesn't exist
+    let result = ucmd.arg("--progress").arg(nonexistent_file).fails();
+
+    // Should contain error message but no progress bar output
+    result
+        .stderr_contains("cannot remove")
+        .stderr_contains("No such file or directory");


I would use new_ucmd! and no result var.

Suggested change

let (_, mut ucmd) = at_and_ucmd!();

let nonexistent_file = "this_file_does_not_exist";

// Test that progress bar is not shown when file doesn't exist

let result = ucmd.arg("--progress").arg(nonexistent_file).fails();

// Should contain error message but no progress bar output

result

.stderr_contains("cannot remove")

.stderr_contains("No such file or directory");

let nonexistent_file = "this_file_does_not_exist";

// Test that progress bar is not shown when file doesn't exist

new_ucmd!()

.arg("--progress")

.arg(nonexistent_file)

.fails()

.stderr_contains("cannot remove")

.stderr_contains("No such file or directory");

src/uu/rm/src/rm.rs

cakebaker

Done :)

codspeed-hq · 2025-10-21T22:27:37Z

CodSpeed Performance Report

Merging #8567 will degrade performances by 3.83%

_{Comparing sylvestre:rm-progress (8bf15fe) with main (0c3eb12)}

Summary

⚡ 4 improvements
❌ 1 regression
✅ 101 untouched
⏩ 73 skipped¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`du_balanced_tree[(5, 4, 10)]`	9.4 ms	9.1 ms	+2.46%
⚡	`du_human_balanced_tree[(5, 4, 10)]`	10.4 ms	10.1 ms	+3.02%
⚡	`du_max_depth_balanced_tree[(6, 4, 10)]`	33.3 ms	32.5 ms	+2.34%
⚡	`du_summarize_balanced_tree[(5, 4, 10)]`	8.6 ms	8.4 ms	+2.65%
❌	`rm_single_file`	99.4 ms	103.4 ms	-3.83%

73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-10-21T22:50:14Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

sylvestre force-pushed the rm-progress branch from c159d96 to b2ad543 Compare September 7, 2025 07:45

sylvestre force-pushed the rm-progress branch from b2ad543 to a423590 Compare September 14, 2025 19:02

sylvestre force-pushed the rm-progress branch from a423590 to 30ccad6 Compare September 14, 2025 20:29

sylvestre force-pushed the rm-progress branch from 30ccad6 to 388bfe6 Compare September 14, 2025 21:13

sylvestre marked this pull request as ready for review September 14, 2025 21:32