who/pinky: fix systemd local host #8672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bakanovskii <[email protected]>
|
GNU testsuite comparison: |
sylvestre
reviewed
Sep 20, 2025
| // If host is local (non-remote) we use display, | ||
| let host = if remote_host.is_empty() { | ||
| String::new() | ||
| display.clone() |
There was a problem hiding this comment.
can we avoid the clone here ?
There was a problem hiding this comment.
I think no, it's later used individually in a last if statement
|
is it possible to test this ? |
It would require systemd so testing this using containers is tricky (https://gist.github.com/alexcpn/549074da9f16119de506af6c5a60ce1e) I will check later if this is possible in a github CI |
So it may be possible but it cannot be added as a job to the current CI due to the required volume mappings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8670