Skip to content

Conversation

bakanovskii
Copy link
Contributor

@bakanovskii bakanovskii commented Sep 20, 2025

Fixes: #8683
Fixes: #8690

Copy link

codspeed-hq bot commented Sep 20, 2025

CodSpeed Performance Report

Merging #8685 will not alter performance

Comparing bakanovskii:df-fix-tracing-zero (146ac84) with main (5c15d79)

Summary

✅ 41 untouched
⏩ 64 skipped1

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

could you please add tests? thanks

@bakanovskii
Copy link
Contributor Author

could you please add tests? thanks

I refactored the tests to cover both modes or should I add a separate test just for mode with tracing zeroes?

@sylvestre
Copy link
Contributor

yeah, please add a test in tests/by-util/test_df.rs too

Copy link

GNU testsuite comparison:

GNU test failed: tests/tail/overlay-headers. tests/tail/overlay-headers is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@bakanovskii
Copy link
Contributor Author

yeah, please add a test in tests/by-util/test_df.rs too

done, however there are some stdbuf error in the CI, is this ok?

Signed-off-by: Alexander Bakanovskii <[email protected]>
@bakanovskii bakanovskii changed the title df: add tracing zero for single digits df: add tracing zero and rounding Sep 29, 2025
Signed-off-by: Alexander Bakanovskii <[email protected]>
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

df: no rounding with -H flag df: no tracing zero in -h
2 participants