Skip to content

cksum: Add support for sha2, sha3 #9035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2025
Merged

cksum: Add support for sha2, sha3 #9035

merged 4 commits into from
Oct 27, 2025

Conversation

@RenjiSann
Copy link
Collaborator

@RenjiSann RenjiSann commented Oct 26, 2025

Fixes #9033

@github-actions
Copy link

github-actions bot commented Oct 26, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum-a is no longer failing!
Congrats! The gnu test tests/cksum/cksum-raw is no longer failing!

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 26, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9035 will degrade performances by 3.22%

Comparing RenjiSann:cksum-fix-sha2-sha3 (3d8ad59) with main (8f6e720)

Summary

❌ 2 regressions
✅ 103 untouched
⏩ 74 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ du_human_balanced_tree[(5, 4, 10)] 10.1 ms 10.4 ms -3.22%
❌ du_wide_tree[(5000, 500)] 11.2 ms 11.5 ms -2.53%

Footnotes

  1. 74 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sylvestre
Copy link
Contributor

sylvestre commented Oct 26, 2025

i guess you saw that the test fails

@RenjiSann RenjiSann force-pushed the cksum-fix-sha2-sha3 branch 3 times, most recently from 700d045 to 800bf7f Compare October 26, 2025 16:50
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-a is no longer failing!
Congrats! The gnu test tests/cksum/cksum-raw is no longer failing!

@RenjiSann RenjiSann force-pushed the cksum-fix-sha2-sha3 branch from 800bf7f to 0387f4e Compare October 26, 2025 17:27
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-a is no longer failing!
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!
Congrats! The gnu test tests/cksum/cksum-raw is no longer failing!

@RenjiSann RenjiSann force-pushed the cksum-fix-sha2-sha3 branch from 0387f4e to 6a53ca4 Compare October 26, 2025 18:12
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-a is no longer failing!
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!
Congrats! The gnu test tests/cksum/cksum-raw is no longer failing!

@RenjiSann RenjiSann force-pushed the cksum-fix-sha2-sha3 branch from 6a53ca4 to 928e77b Compare October 26, 2025 19:00
@RenjiSann RenjiSann force-pushed the cksum-fix-sha2-sha3 branch from 928e77b to 3d8ad59 Compare October 26, 2025 19:18
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-a is no longer failing!
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!
Congrats! The gnu test tests/cksum/cksum-raw is no longer failing!

@RenjiSann
Copy link
Collaborator Author

RenjiSann commented Oct 27, 2025

That should be ready for review :)

@RenjiSann RenjiSann requested a review from sylvestre October 27, 2025 09:41
sylvestre
sylvestre reviewed Oct 27, 2025
View reviewed changes
src/uucore/src/lib/features/checksum.rs
match length {
Some(len @ (224 | 256 | 384 | 512)) => Ok(len),
Some(len) => {
show_error!("invalid length: '{len}'");
Copy link
Contributor

@sylvestre sylvestre Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use translate!()
(maybe do that in a different pr)

Copy link
Collaborator Author

@RenjiSann RenjiSann Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue so we can do it after we are finished fixing all cksum tests #9047

@sylvestre sylvestre merged commit 0be1ac8 into uutils:main Oct 27, 2025
121 of 122 checks passed
@sylvestre
Copy link
Contributor

sylvestre commented Oct 27, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-a is no longer failing!
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!
Congrats! The gnu test tests/cksum/cksum-raw is no longer failing!

it has been a while we fixed 3 at the same time :)

@cakebaker cakebaker mentioned this pull request Oct 27, 2025
Open
@RenjiSann RenjiSann deleted the cksum-fix-sha2-sha3 branch October 30, 2025 16:39
@RenjiSann RenjiSann mentioned this pull request Oct 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cksum: Add support for sha2, sha3

2 participants

@RenjiSann @sylvestre