Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Oct 26, 2025

Don't try to install part of hashsum if we excluded hashsum.

Test on main is blocked by wrong install operation. This should fix it.
related #9009

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 26, 2025

CodSpeed Performance Report

Merging #9036 will improve performances by 3.04%

Comparing oech3:clear-hashsum (026ef1b) with main (28bc57a)

Summary

⚡ 2 improvements
✅ 103 untouched
⏩ 74 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
du_human_balanced_tree[(5, 4, 10)] 10.4 ms 10.1 ms +3.04%
du_summarize_balanced_tree[(5, 4, 10)] 8.5 ms 8.3 ms +2.54%

Footnotes

  1. 74 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@oech3 oech3 requested a review from cakebaker October 26, 2025 15:59
@oech3
Copy link
Contributor Author

oech3 commented Oct 26, 2025

Ready to merge. hashsum multicall is complex at least for me...

@cakebaker cakebaker merged commit 8f6e720 into uutils:main Oct 26, 2025
121 checks passed
@oech3 oech3 deleted the clear-hashsum branch October 26, 2025 16:25
@cakebaker
Copy link
Contributor

Thanks!

Ready to merge. hashsum multicall is complex at least for me...

Yeah, hopefully we can get rid of it in the future.

@oech3
Copy link
Contributor Author

oech3 commented Oct 26, 2025

Would you fix #9009 too? I'll drop extra option if needed. (Failing is CodSpeed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants