-
Notifications
You must be signed in to change notification settings - Fork 214
docs: update articles for moved vaadin-dev #4778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
vaadin-dev dependency is moved from vaadin-core to vaadin-spring-boot-starter. Jakarta EE starters are updated for production ready builds with 'mvn clean package'. PartOf: vaadin/flow#22715
|
Other places where production profiles is also mentioned:
|
vaadin-dev is not included transitively by any Vaadin dependency.
|
|
| ---- | ||
|
|
||
| Or when building Spring Boot 4 application, add `vaadin-dev` dependency as a `optional` scope in project `<dependencies>`. Spring Boot 4 `spring-boot-maven-plugin` automatically excludes optional dependencies from the final build: | ||
| The Vite server integration and live reload features -- which are available only in development builds -- are contained in the `com.vaadin:vaadin-dev-server` module. You should exclude this module when building a production package. You can exclude it by adding `vaadin-dev` dependency as a `optional` scope in project `<dependencies>`. Spring Boot 4 `spring-boot-maven-plugin` automatically excludes optional dependencies from the final build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional breaks projects such skeleton-starter-flow-cdi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean when optional is added added here: https://github.com/vaadin/skeleton-starter-flow-cdi/blob/v25/pom.xml
v25 branch don't need optional since it has development profile adding vaadin-dev. It's an exception and maybe need to be clarified somehow better when optional is actually needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrote it to more specific when excluding is needed.
| When you use `vaadin-dev` in your Maven configuration to run in development mode -- within the same Maven profile or project dependencies -- you should exclude this module from the production package. | ||
|
|
||
| Or when building Spring Boot 4 application, add `vaadin-dev` dependency as a `optional` scope in project `<dependencies>`. Spring Boot 4 `spring-boot-maven-plugin` automatically excludes optional dependencies from the final build: | ||
| You can do this by declaring the `vaadin-dev` dependency `optional` in your project `<dependencies>`. Maven automatically excludes optional dependencies from the final production package: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no changes to https://vaadin.com/docs/v25/flow/configuration/development-mode, but I think we need to instruct devs how to configure development config according to the new approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated development-mode page. And added link from upgrade guide.
vaadin-dev dependency is removed from vaadin-core. Jakarta EE starters are updated for production ready builds with 'mvn clean package'.
PartOf: vaadin/flow#22715