Skip to content

Conversation

@mcollovati
Copy link
Contributor

@mcollovati mcollovati requested a review from heruan November 26, 2025 07:00
@mcollovati mcollovati added the target/main cherry pick to main branch label Nov 26, 2025
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

AI Language Review

The updated AsciiDoc file introduces a new section, "Common Settings," and adds properties with descriptions and default values to an organized table format. There are a few considerations:

  1. Consistency in Terminology: In the "Hazelcast for Session Replication" section:

    • Ensure consistent terminology for "service-name" and "service-port" properties throughout the document. Ensure both terms are consistently hyphenated.
  2. Section Introduction: For the newly added "Common Settings" table, consider providing a brief introduction to explain the purpose of these settings. This helps provide context to the reader, especially for new sections.

  3. Additional Examples: In the "Hazelcast for Session Replication" aside note, it mentions a specific configuration for a HazelcastInstance bean. Consider adding a brief example to illustrate the configuration with hazelcast.shutdownhook.enabled=false.

These improvements will enhance clarity and consistency across the document.

@mshabarov mshabarov merged commit 477c28e into v24 Dec 3, 2025
4 checks passed
@mshabarov mshabarov deleted the docs/kk-configuration branch December 3, 2025 18:09
vaadin-bot pushed a commit that referenced this pull request Dec 3, 2025
* docs: improve Kubernetes Kit configuration documentation

Fixes vaadin/kubernetes-kit#248

* vale fixes

* Apply suggestion

* Update articles/tools/kubernetes/configuration.adoc

Co-authored-by: Giovanni Lovato <[email protected]>

---------

Co-authored-by: Giovanni Lovato <[email protected]>
Co-authored-by: Mikhail Shabarov <[email protected]>
peholmst added a commit that referenced this pull request Dec 4, 2025
* docs: improve Kubernetes Kit configuration documentation

Fixes vaadin/kubernetes-kit#248

* vale fixes

* Apply suggestion

* Update articles/tools/kubernetes/configuration.adoc



---------

Co-authored-by: Marco Collovati <[email protected]>
Co-authored-by: Giovanni Lovato <[email protected]>
Co-authored-by: Mikhail Shabarov <[email protected]>
Co-authored-by: Petter Holmström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document new configuration properties

6 participants