-
Notifications
You must be signed in to change notification settings - Fork 214
Updates to Flow docs related to styling changes in V25 #4852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AI Language ReviewThe only change between the "Hot Deploy & Live Reload" versions is the heading text for frontend changes. It now specifies changes to stylesheets and other frontend resources, but the rest of the content has not been altered. There are no issues requiring improvement based on the provided excerpt. The "Source Control" file has been altered to update directory and folder naming examples, presumably for accuracy or clarity. The changes appear to be correctly in line with best practices. Thus, there are no issues to address or corrections needed. Regarding the "Loading Resources" file modification, the only change appears in one section under "Dependency Loading Order". However, this change does not introduce any problems or require any corrections. Therefore, no issues require improvement in the provided changes. |
| └── resources | ||
| └── test/ <8> | ||
| └── META-INF | ||
| └── resources <5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could extend this structure a bit and show a pair of css files in directories, e.g.:
└── META-INF
└── resources
└── css
└── main-view.css
└── styles.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit worried about showing a subfolder under resources, as it might be interpreted as being part of the typical structure and/or recommended structure. Perhaps it would be sufficient to add a styles.css in the root and mention in the bullet for resources that you can put subfolders there?
Co-authored-by: Mikhail Shabarov <[email protected]>
No description provided.