Skip to content

Conversation

@sissbruecker
Copy link
Contributor

Simplify the basic Scroller example to just show a card with some Markdown content. This makes the example work out of the box with both Lumo and Aura.

Copy link
Contributor

@vursen vursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overflow indicators look a bit strange in this example, do we actually need them? Otherwise LGTM.

Image

@jouni
Copy link
Member

jouni commented Dec 9, 2025

The overflow indicators look a bit strange in this example

Happens only in the Flow example, where there’s an extra <div style="display: contents"> element wrapping the <vaadin-scroller>. That prevents this selector from matching: https://github.com/vaadin/web-components/blob/b52505a031db01d2aba91ec4126d6cf98c9becd3/packages/card/src/styles/vaadin-card-base-styles.js#L252-L260

Those should actually be updated to use the --vaadin-scroller-padding-inline property, and we can then remove the selectors targeting the scroller pseudo elements.

@sissbruecker sissbruecker merged commit e338e22 into main Dec 9, 2025
3 checks passed
@sissbruecker sissbruecker deleted the refactor/simplify-scroller-basic-example branch December 9, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants