Skip to content

Conversation

@ugur-vaadin
Copy link
Contributor

Description

This PR updates the validation logic for DatePicker and TimePicker so that the value is preserved on setting unparsable input in a field with a valid value.

Fixes #8209

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen force-pushed the fix-preserve-value-on-unparsable-input branch from 7078e69 to 0e492f0 Compare November 11, 2025 12:34
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.0% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@vursen vursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reported issue seems to be in Binder rather than the component. This PR would introduce a major behavior change that might break other applications.

@ugur-vaadin
Copy link
Contributor Author

Let's keep the PR in draft until we get a response from the Flow team.

@ugur-vaadin ugur-vaadin marked this pull request as draft November 11, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DatePicker not sending null value to binder after deleting invalid value

3 participants