Create an actual Badget component #8239
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's create a new Java API for Badge component. This component is special from it's client-side implementation in a way that there is no web component for it. Technically it is just a set of style rules. But for Java developers it is a component like others. A clean Java API will help users to use it from IDE. The official documentation currently makes developers use the lower level Element API (via getElement()), use "faceless" Span component (which many Java developers don't know of) and use "magic strings" in theme list (which is also a strange concept we want to hide). Although the component is essentially just CSS rules, the implementation should have a set of tests, from which we can ensure it looks appropriate at least manually. Also elsewhere (in project structure and Java code style), try to re-use the same principles as with other components, even if the client-side implementation is bit different to most other Vaadin components. Investigate also these as references: Issue that discribes the missing feature: vaadin/web-components#5379 Current documentation how to use it: https://vaadin.com/docs/v25/components/badge A community developed version of this component (uses CSS copied into that project, this should use core Lumo theme rules directly): https://github.com/viritin/flow-viritin/blob/v24/src/main/java/org/vaadin/firitin/components/badge/Badge.java
Now compiles and it project shows something meaningful
Collaborator
TC Format Checker Report - 09:44 - 05 - Nov
Here is the list of files with format issues in your PR: |
|
web-padawan
requested changes
Nov 19, 2025
Member
web-padawan
left a comment
web-padawan
left a comment
There was a problem hiding this comment.
Blocking this PR for now, it needs to wait at least until 25.1 as we have now reached a feature freeze for 25.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5379
Type of change